Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/use major versions #1291

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fistach
Copy link

@fistach fistach commented Apr 24, 2024

  • a GitHub Issue was opened for this feature / bug.
  • test coverage was added (Cucumber or Spock as appropriate).

Fixes #603

It partially resolves issues mentioned in the #603. I think the tests describe well the intention of this PR.

@fistach fistach force-pushed the feature/use-major-versions branch from d6d9d88 to f90d907 Compare April 24, 2024 19:46
…evious grails test

because the test framework is sensitive to "java" name
@FilipStachowiak-TomTom
Copy link

Please note that the tests are sensitive when it comes to item names. If you take existing tests and rename 'java' to 'elephant', some of them will fail.

@marc0der
Copy link
Member

marc0der commented May 26, 2024

Hi @fistach, thank you for the immaculate PR!

It's a pity you didn't speak to me about the work you were about to embark on because the changes you made are in the legacy codebase. We are no longer developing this, and all the bash components will be dismantled soon. I'll add a clear section to the top of the README about this so that others don't get caught out in the future.

Another comment I had was that the changes were only for the use command, which would leave the CLI in an inconsistent state. If this works for use, it should also work for install and default.

I'm writing a new backend service for the new Rust CLI that will enable this behaviour out of the box for all the commands I mentioned above.

Update: Added this notice to the README

@fistach
Copy link
Author

fistach commented May 27, 2024

Hi Marco.
No problem.
But if I add the rest of changes, will you re-consider clicking the "release" button of this tool?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to manage aliases for a major version of a tool
4 participants